curl_setup.h: move UWP detection after config-win32.h#17980
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
curl_setup.h: move UWP detection after config-win32.h#17980vszakats wants to merge 2 commits intocurl:masterfrom
config-win32.h#17980vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
Member
Author
|
Solving this problem created another: I'm not sure which bug causes less issues. The use-case is very niche: edit: The |
3 tasks
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Jul 24, 2025
This change wasn't good because `config-win32.h` does rely on the UWP detection result to set `USE_WIN32_CRYPTO` and LDAP macros. While it fixed one issue, it created another. It seems better to revert, and focus on reducing and/or eventually dropping the logic within `config-win32.h` that alters `_WIN32_WINNT`. It may not be necessary anymore with a minimum of VS2008 (soon VS2010). The logic is also absent from cmake builds, without causing issues. Builds affected winbuild/project-file for UWP. These are theoretical builds because neither build method is prepared to target UWP. Reverts 792a61e curl#17980
vszakats
added a commit
that referenced
this pull request
Jul 24, 2025
This change wasn't good because `config-win32.h` does rely on the UWP detection result to set `USE_WIN32_CRYPTO` and LDAP macros. While it fixed one issue, it created another. It seems better to revert, and focus on reducing and/or eventually dropping the logic within `config-win32.h` that alters `_WIN32_WINNT`. It may not be necessary anymore with a minimum of VS2008 (soon VS2010). The logic is also absent from cmake builds, without causing issues. Could affect UWP winbuild/project-file builds. These are theoretical builds because neither build method is prepared to target UWP. Reverts 792a61e #17980 Ref: #17980 (comment) Closes #18014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To honor a
_WIN32_WINNTset byconfig-win32.h.