cmake: Check USE_WINDOWS_SSPI instead of CURL_WINDOWS_SSPI when adding secur32 to CURL_LIBS#17728
Closed
JDepooter wants to merge 1 commit intocurl:masterfrom
Closed
cmake: Check USE_WINDOWS_SSPI instead of CURL_WINDOWS_SSPI when adding secur32 to CURL_LIBS#17728JDepooter wants to merge 1 commit intocurl:masterfrom
JDepooter wants to merge 1 commit intocurl:masterfrom
Conversation
Member
|
Thank you, merged! |
whrvt
added a commit
to neomodnet/neomod
that referenced
this pull request
Jul 22, 2025
maybe these are related? curl/curl#17728 curl/curl#17982 curl/curl#17979 idk what the downsides of this are though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running CMake on Windows with no additional parameters (ie default build configuration), the generated project files do not include the
secur32.liblibrary in the linker settings. This is because the relevant check was looking atCURL_WINDOWS_SSPIinstead ofUSE_WINDOWS_SSPI.USE_WINDOWS_SSPIis enabled when building with SChannel (the default on Windows), or ifCURL_WINDOWS_SSPIis specified on the command line.Follow-up to 0d71b18 #17413