tool_cb_rea: simplify reading stdin non-blocking#17569
Closed
Conversation
To improve performance at the expense of doing more loops.
|
Analysis of PR #17569 at 712f8fc4: Test ../../tests/http/test_07_upload.py::TestUpload::test_07_70_put_earlydata[h3-limited-body] failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
Contributor
|
the early data test failed with other PRs sometimes as well. Seems I need to check what is going on there. |
Contributor
|
Have rolled this into #17566 along with a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve performance at the expense of doing more loops.
Alternative to #17566, meant to simplify.