Skip to content

lib3026: drop DLL pre-load perf mitigation for old mingw#17414

Closed
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:test3026
Closed

lib3026: drop DLL pre-load perf mitigation for old mingw#17414
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:test3026

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented May 22, 2025 •
edited
Loading

curl no longer supports old/legacy/classic mingw.

This mitigation was addressing slow perf seen in CI with old mingw.
The slow perf is not seen in current CI with supported compilers.

Remove the duplicate DLL load function from libtest. It's no longer
used after this patch.

Current CI run times for test3026 on GHA/windows:

test 3026...[curl_global_init thread-safety]
 # mingw, CM clang-x86_64 gnutls libssh
 -------e--- OK (1715 out of 1738, remaining: 00:02, took 0.196s, duration: 02:55)
 # dl-mingw, CM 9.5.0-x86_64 schannel
 -------e--- OK (1554 out of 1577, remaining: 00:02, took 0.217s, duration: 02:29)
 # msvc, CM x64-windows schannel +examples
 -------e--- OK (1578 out of 1601, remaining: 00:02, took 0.205s, duration: 02:50)

Follow-up to 3802910 #11625
Follow-up to 856b133 #9412
Ref: #17413

@vszakats
lib3026: stop pre-loading DLLs to mitigate old mingw perf issue
004445e 
curl no longer supports old mingw.

Follow-up to 3802910 curl#11625
Follow-up to 856b133 curl#9412
@vszakats vszakats added tests Windows Windows-specific labels May 22, 2025
@vszakats vszakats mentioned this pull request May 22, 2025
Closed
3 tasks
@vszakats vszakats changed the title lib3026: stop pre-loading DLLs to mitigate old mingw perf issue lib3026: drop DLL pre-load perf mitigation targeting old mingw May 22, 2025
@vszakats

This comment was marked as resolved.

Sign in to view
@vszakats vszakats changed the title lib3026: drop DLL pre-load perf mitigation targeting old mingw lib3026: drop DLL pre-load perf mitigation for old mingw May 23, 2025
@vszakats vszakats closed this in a0a1df5 May 23, 2025
@vszakats vszakats deleted the test3026 branch May 23, 2025 09:59
@vszakats vszakats mentioned this pull request May 23, 2025
Closed
vszakats added a commit to vszakats/curl that referenced this pull request Jun 27, 2025
@vszakats
tests/libtests: drop a checksrc exception
d7c5ab4 
Follow-up to a0a1df5 curl#17414
@vszakats vszakats mentioned this pull request Jun 27, 2025
Closed
vszakats added a commit that referenced this pull request Jun 27, 2025
@vszakats
tests/libtest: drop a checksrc exception
344ccb0 
Follow-up to a0a1df5 #17414

Closes #17762
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

tests tidy-up Windows Windows-specific

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vszakats @bagder