curl_multibyte: fixup low-level calls, include in unity builds#16742
Closed
vszakats wants to merge 8 commits intocurl:masterfrom
Closed
curl_multibyte: fixup low-level calls, include in unity builds#16742vszakats wants to merge 8 commits intocurl:masterfrom
vszakats wants to merge 8 commits intocurl:masterfrom
Conversation
lib/curl_multibyte.c into unitylib/curl_multibyte.c into unity
lib/curl_multibyte.c into unity
Member
|
The comment at the head of this file should be updated to explain why all functions in the file must now call the original versions of memory functions. For example,. /*
* The functions in this file are curlx functions which are not tracked by the
* curl memory tracker memdebug so they do not use the macro replacements
* free, malloc, etc. Instead wrap the names in parentheses to call the
* original versions: `ptr = (malloc)(123)`, `(free)(ptr)`, etc.
*/ |
Member
Author
|
That comment could use an update indeed. I also learned about test 1132, I guess the root reason we don't want to call the debug allocators from these Updated the comment! |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 19, 2025
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
This reverts commit a5cd709.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Mar 19, 2025
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
Also adjust `()` around low-level calls preventing macro overrides via e.g. `memdebug.h`: - add for `malloc` and `free`. - drop for `_open`. (We do not override `_open` in curl.) Tidy-up: also sync libcurlu custom macro order in cmake with autotools. Follow-up to f42a279 curl#11928 Closes curl#16742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adjust
()around low-level calls preventing macro overrides viae.g.
memdebug.h:mallocandfree._open. (We do not override_openin curl.)Tidy-up: also sync libcurlu custom macro order in cmake with autotools.
Follow-up to f42a279 #11928