curl.h: switch CURL_HTTP_VERSION* enums to long constants#16580
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
curl.h: switch CURL_HTTP_VERSION* enums to long constants#16580vszakats wants to merge 3 commits intocurl:masterfrom
CURL_HTTP_VERSION* enums to long constants#16580vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
CURL_HTTP_VERSION* enums to long constants
CURL_HTTP_VERSION* enums to long constantsCURL_HTTP_VERSION* enums to long constants
bagder
approved these changes
Mar 5, 2025
1 task
|
[EDIT] suppressed error due to an unrelated commit, sorry for the noise. |
Member
Author
That isn't related to this commit, but 2ec0037 #16482, where it was reported earlier, and I linked the CMake patch that fixed it downstream: #16482 (comment) I think the answer is CMake was using a non-public type here (but I may be confusing this with another case and no time to archeologe into this now.) |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
It fixes tests 1539, and 2402, 2404 (for non-Secure Transport), on macOS with the gcc compiler. Also unignore these tests in GHA/macos for non-secure transport. Ref: c349bd6 curl#14097 (issue 15.) Ref: 7b0240c curl#16539 Ref: 2ec0037 curl#16482 Closes curl#16580
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes tests 1539, and 2402, 2404 (for non-Secure Transport), on macOS
with the gcc compiler.
Also unignore these tests in GHA/macos for non-secure transport.
Ref: c349bd6 #14097 (issue 15.)
Ref: 7b0240c #16539
Ref: 2ec0037 #16482