build: disable warning -Wunreachable-code-break#15416
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
build: disable warning -Wunreachable-code-break#15416vszakats wants to merge 1 commit intocurl:masterfrom
-Wunreachable-code-break#15416vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
This warning remains silent in unity builds. Since we're using unity build in CI for most jobs, warnings remain undetected there. Disable them for all builds to avoid a surprise warning outside our CI. The issue caught by the warning is useful for a tidy codebase, but doesn't affect executed code. It was enabled in 84338c4 curl#12331 (2023-11-15). llvm source: https://github.com/llvm/llvm-project/blob/fee2953f23bd8a8a71e574e6a8db08033778d3a4/clang/lib/Sema/AnalysisBasedWarnings.cpp#L125-L134 llvm issue: llvm/llvm-project#71046 Follow-up to 7c023c3 curl#15384
Contributor
|
Analysis of PR #15416 at 2e771c41: Test 271 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This warning remains silent in unity builds. Since we're using unity in CI for most jobs, warnings remain undetected there. Disable them for all builds to avoid a surprise warning outside our CI. The issue caught by the warning is useful for a tidy codebase, but doesn't affect executed code. It was enabled in 84338c4 curl#12331 (2023-11-15). llvm source: https://github.com/llvm/llvm-project/blob/fee2953f23bd8a8a71e574e6a8db08033778d3a4/clang/lib/Sema/AnalysisBasedWarnings.cpp#L125-L134 llvm issue: llvm/llvm-project#71046 Follow-up to 7c023c3 curl#15384 Closes curl#15416
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning remains silent in unity builds. Since we're using unity
in CI for most jobs, warnings remain undetected there.
Disable them for all builds to avoid a surprise warning outside our CI.
The issue caught by the warning is useful for a tidy codebase, but
doesn't affect executed code. It was enabled in
84338c4 #12331 (2023-11-15).
llvm source: https://github.com/llvm/llvm-project/blob/fee2953f23bd8a8a71e574e6a8db08033778d3a4/clang/lib/Sema/AnalysisBasedWarnings.cpp#L125-L134
llvm issue: llvm/llvm-project#71046
Follow-up to 7c023c3 #15384