build: tidy up deprecation suppression, enable warnings for clang#14789
Closed
vszakats wants to merge 15 commits intocurl:masterfrom
Closed
build: tidy up deprecation suppression, enable warnings for clang#14789vszakats wants to merge 15 commits intocurl:masterfrom
vszakats wants to merge 15 commits intocurl:masterfrom
Conversation
- examples: suppression moved to C-level, to help those compiling the examples directly - http/client: never needed this option
CURL_DISABLE_DEPRECATION usesCURL_DISABLE_DEPRECATION use
CURL_DISABLE_DEPRECATION usede111c2 to
fd0cd4e
Compare
This reverts commit fd0cd4e.
Member
Author
|
Tried to enable deprecation warnings for MSVC, but it fell over because |
19 tasks
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Suppress deprecation warnings the closest to the deprecated code, using `CURL_IGNORE_DEPRECATION()`. Then drop build-specific suppressions, and file-wide ones. The latter is not compatible with Unity mode. Also replace manual suppressions with a macro to apply to all compilers with deprecation warning support. Also enable deprecation warnings for clang. - curl/curl.h: enable deprecation warnings for clang. - docs/examples: stop setting `CURL_DISABLE_DEPRECATION` with autotools. Suppression moved to C-level earlier. Syncs with cmake. Follow-up to 5fc61a3 curl#14123 - tests/http/clients: stop setting `CURL_DISABLE_DEPRECATION` in autotools. If it becomes necessary in the future, it can be done in C via the macro. Syncs with cmake. - lib1545: stop setting `CURL_DISABLE_DEPRECATION` in autotools. Drop guard from test source. Follow-up to 0f10360 curl#12444 - libtest, unit: replace `CURL_DISABLE_DEPRECATION` with `CURL_IGNORE_DEPRECATION()`. - docs/examples: replace pragmas with `CURL_IGNORE_DEPRECATION()`. Closes curl#14789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress deprecation warnings the closest to the deprecated code, using
CURL_IGNORE_DEPRECATION(). Then drop build-specific suppressions, andfile-wide ones. The latter is not compatible with Unity mode. Also
replace manual suppressions with a macro to apply to all compilers with
deprecation warning support. Also enable deprecation warnings for clang.
curl/curl.h: enable deprecation warnings for clang.
docs/examples: stop setting
CURL_DISABLE_DEPRECATIONwith autotools.Suppression moved to C-level earlier. Syncs with cmake.
Follow-up to 5fc61a3 examples: suppress deprecation warnings locally #14123
tests/http/clients: stop setting
CURL_DISABLE_DEPRECATIONinautotools. If it becomes necessary in the future, it can be done in
C via the macro. Syncs with cmake.
lib1545: stop setting
CURL_DISABLE_DEPRECATIONin autotools.Drop guard from test source.
Follow-up to 0f10360 test1545: disable deprecation warnings #12444
libtest, unit: replace
CURL_DISABLE_DEPRECATIONwithCURL_IGNORE_DEPRECATION().docs/examples: replace pragmas with
CURL_IGNORE_DEPRECATION().w/o whitespace: https://github.com/curl/curl/pull/14789/files?w=1