build: check OS-native IDN first, then libidn2#14674
Closed
vszakats wants to merge 8 commits intocurl:masterfrom
Closed
build: check OS-native IDN first, then libidn2#14674vszakats wants to merge 8 commits intocurl:masterfrom
vszakats wants to merge 8 commits intocurl:masterfrom
Conversation
Similarly how it was done for WinIDN and how cmake works for both AppleIDN and WinIDN.
3851dc4 to
f9b3831
Compare
13 tasks
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If AppleIDN or WinIDN is selected, don't look for libidn2. Do this by
moving libidn2 detection after AppleIDN/WinIDN and skipping it if any
of them was selected.
Also:
CMake.
Before this patch libidn2 was detected by default even if AppleIDN or
WinIDN was explicitly selected. libidn2 wasn't used in the build, but
it was left enabled as a dependency and appeared in
libcurl.pcandcurl-config.w/o whitespace: https://github.com/curl/curl/pull/14674/files?w=1