cmake: tidy up more value comparisons#14449
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
Conversation
- unquote numeric value.
- replace macro with variable name.
It also avoids this error when the variable is undefined:
```
CMake Error at CMakeLists.txt:1529 (if):
if given arguments:
"GREATER" "4"
Unknown arguments specified
```
https://github.com/curl/curl/actions/runs/10289921657/job/28478722584#step:30:356
Follow-up to 72ae0d8 curl#14409
Follow-up to acbc6b7 curl#14197
Closes #xxxxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unquote numeric value.
NOT LESS->GREATER_EQUAL.replace macro with variable name.
It also avoids this error when the variable is undefined:
https://github.com/curl/curl/actions/runs/10289921657/job/28478722584#step:30:356
Follow-up to 72ae0d8 #14409
Follow-up to acbc6b7 #14197
Closes #14449