CI: realign cmake build settings (for nghttp2, libidn2)#14364
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
CI: realign cmake build settings (for nghttp2, libidn2)#14364vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
It's now on by default, adjust build configuration accordingly. Follow-up to 87aa4eb curl#14136 Closes #xxxxx
USE_NGHTTP2= after changed cmake defaultUSE_NGHTTP2= with changed cmake default
USE_NGHTTP2= with changed cmake defaultUSE_NGHTTP2= with changed cmake default
USE_NGHTTP2= with changed cmake default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nghttp2 is now on by default, adjust build configuration accordingly.
Follow-up to 87aa4eb cmake: detect
nghttp2viapkg-config, enable by default #14136GHA/macos: disable libidn2 in combination builds, syncing with autotools.
Otherwise it's now auto-detected via pkg-config by default.
Follow-up to f43adc2 cmake: detect
libidn2also viapkg-config#14137Closes #14364