Conversation
FindNettle.cmake
|
I wonder how this could be caught in CI. There is a test, but I guess we'd need separate ones to touch each |
|
Unless we can write a parser that figures out what modules we use and then check that they are all present... |
|
You can create test that curl compile with other library/program (curl is a 3rd party) and check this things. |
|
Similar to test, but test have different cmake that don't depends on curl cmake. |
|
Here's an attempt to test this in CI (and locally with the |
Follow-up to 669ce42 curl#14285 Reported-by: Christoph Reiter Bug: curl#14285 (comment) Closes curl#14320
sure, but then we would need to make builds (from a dist tarball) for all dependencies that use a cmake module |
|
Maybe the bug can reproduce without the distro tar ball, with simple make install for curl and install dependencies with apt get or similar. Write other cmake that will try to find curl and it dependencies. |
|
The tarball or building anything is unnecessary. I went with a CMake custom option that reads |
|
I think we talking here about more errors that can be found with cmake builds and make them automatic. |
- add CMake option to verify if the `CMake/*.cmake`, `CMake/*.in` files are listed as distributable in autotools' `EXTRA_DIST`. The check can be enabled with `-DENABLE_DIST_TEST=ON` CMake option. - add CI job to that effect. Ref: curl#14320 Closes curl#14323
Follow-up to 669ce42 #14285
Reported-by: Christoph Reiter
Bug: #14285 (comment)
Closes #14320