cmake: drop if(PKG_CONFIG_FOUND) guard for pkg_check_modules()#14309
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: drop if(PKG_CONFIG_FOUND) guard for pkg_check_modules()#14309vszakats wants to merge 1 commit intocurl:masterfrom
if(PKG_CONFIG_FOUND) guard for pkg_check_modules()#14309vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
The oldest cmake supported by curl is 3.7.0, which already has a guard inside `pkg_check_modules()`. The advantage of leaving that to CMake is that it will define/reset all variables, while the manual guard doesn't do this and also leave `NETTLE_FOUND` undefined. Delete the single use of this check in the recently added NETTLE patch by accident. And re-introduce this later everywhere if we find it useful after more evaluation. Follow-up to 669ce42 curl#14285 Closes curl#14309
if(PKG_CONFIG_FOUND) around pkg_check_modules()if(PKG_CONFIG_FOUND) guard for pkg_check_modules()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oldest cmake supported by curl is v3.7.0, which already has such
guard (using
PKG_CONFIG_EXECUTABLE) insidepkg_check_modules(). Theadvantage of leaving that guard to CMake is that it will define/reset
all output variables, while the manual guard doesn't do this and also
leaves for example
NETTLE_FOUNDundefined.Delete the single use of this guard from the recently added
nettledetection, where I included it by accident. Then possibly re-introduce
it universally if we find it useful after more evaluation.
Follow-up to 669ce42 #14285
Closes #14309