GHA/non-native: improve, migrate x86_64 FreeBSD with tests from Cirrus CI#14244
Closed
vszakats wants to merge 22 commits intocurl:masterfrom
Closed
GHA/non-native: improve, migrate x86_64 FreeBSD with tests from Cirrus CI#14244vszakats wants to merge 22 commits intocurl:masterfrom
vszakats wants to merge 22 commits intocurl:masterfrom
Conversation
Member
Author
|
Member
Author
|
The only two problems seen compared to Cirrus were these two: https://github.com/curl/curl/actions/runs/10020191246/job/27697561609#step:3:10382 These fail in Cirrus, but not in GHA: |
Closes #xxxxx
check runs tests with -am which enables automake style and short output, which misses some details compared to the cirrus FreeBSD runs (and macOS too)
The only two problems seen compared to cirrus were these two: ``` TESTINFO: "failed starting neg TELNET server" 1 time (1452) TESTINFO: "failed starting DICT server" 1 time (1450) ``` https://github.com/curl/curl/actions/runs/10020191246/job/27697561609#step:3:10382
988ffe3 to
a602d1d
Compare
Member
Author
|
Is there any objection to migrate our FreeBSD Intel CI job from Cirrus CI to GHA? |
vszakats
pushed a commit
that referenced
this pull request
Aug 3, 2024
The test-ci target now uses 2 processes by default, but the amount of parallelism is tuned for each CI service and build environment based on results of a number of test runs. Some CI services use super- oversubscribed build machines that can barely run the curl tests already with no parallelism without frequently failing with timing-induced failures. These continue to be run without parallelism. Other services provide two fast, unloaded cores and these run with 14 processes, which is a good default for this kind of environment. Here's a summary of the number of test processes by CI service: Appveyor - 2 (Windows MSVC), 1 (others) Azure - 2 Circle CI - 14 Cirrus - 28 (macOS), 14 (Linux), 7 (FreeBSD), 5 (macOS torture), 2 (Windows) GitHub Actions - 3 (macOS), 2 (Linux) Some of these are a bit conservative to keep timing-induced flakiness down. The net result is that the first test results should arrive only 3 minutes after a commit submission. Already merged via separate commits: - 2a7c8b2 #14171 - 7234106 - efce544 #14244 - c6cf411 Ref: #10818 Closes #11510
vszakats
pushed a commit
that referenced
this pull request
Aug 3, 2024
The test-ci target now uses 2 processes by default, but the amount of parallelism is tuned for each CI service and build environment based on results of a number of test runs. Some CI services use super- oversubscribed build machines that can barely run the curl tests already with no parallelism without frequently failing with timing-induced failures. These continue to be run without parallelism. Other services provide two fast, unloaded cores and these run with 14 processes, which is a good default for this kind of environment. Here's a summary of the number of test processes by CI service: Appveyor - 2 (Windows MSVC), 1 (others) Azure - 2 Circle CI - 14 Cirrus - 28 (macOS), 14 (Linux), 7 (FreeBSD), 5 (macOS torture), 2 (Windows) GitHub Actions - 3 (macOS), 2 (Linux) Some of these are a bit conservative to keep timing-induced flakiness down. The net result is that the first test results should arrive only 3 minutes after a commit submission. Changes merged via separate commits: - 2a7c8b2 #14171 - 7234106 - efce544 #14244 - c6cf411 Ref: #10818 Closes #11510
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make test-ciinstead ofmake checkwith autotools.x86_64job for FreeBSD, with tests.It matches the existing Cirrus CI job, with these differences:
(already past the removal deadline, thought the package still
installs.)
It means skipping test 1450 and 1452.
pkg update -f.CRYPTOGRAPHY_DONT_BUILD_RUST=1,pkg delete curl,chmod 777,sudo -u nobodyandsysctl net.inet.tcp.blackholetricks. The latter is the default in these runners, the others did
not affect results.
-j0for tests in the NetBSD job. Flaky otherwise.Closes #14244