GHA: Unify http3 workflows into one#13841
Closed
tatsuhiro-t wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
This commit unifies the following http3 workflows into http3-linux.yml: - ngtcp2-linux.yml - osslq-linux.yml - quiche-linux.yml The idea is better use of the build cache. Previously, they independently create caches with the same key. Some of the caches include source code and intermediate object files, which makes cache quite large. In this commit, only built artifacts are cached, which drastically reduces the cache size. OpenSSL v3, mod_h2 and quiche caches still include all stuff, but they are left for the later improvement. Because the contents of the cache have been changed, the cache keys are also changed to include the word "http3".
Contributor
|
cc @MAntoniak, in case you're interested. |
Contributor
Hmm, not really. I think you mean #13838 :) |
bagder
approved these changes
Jun 1, 2024
Member
|
Thanks! |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Oct 24, 2025
Also: - http3-linux: replace hard-coded workflow name with variable. Follow-up to a817417 curl#13841 - codeql: set `cancel-in-progress: true`. - codeql: sync concurrency setting with the rest of the jobs. I admit to not grasp how concurrency settings works and if there is supposed to be a special case for codeql. Expressions used (before and after this patch): - group: ${{ github.workflow }}-${{ github.event.sha }}-${{ github.event.target_url }} for GHA/appveyor-status. - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} for all the rest.
vszakats
added a commit
that referenced
this pull request
Oct 24, 2025
To silence zizmor 1.16.0 warnings. Also: - http3-linux: replace hard-coded workflow name with variable. Follow-up to a817417 #13841 - codeql: set `cancel-in-progress: true`. zizmor apparently does not allow `false` in pedantic mode anymore: zizmorcore/zizmor#1227 - codeql: sync concurrency setting with the rest of the jobs. (I'm not sure this is correct, or why it was previously special-cased.) Expressions used (before and after this patch): - `group: ${{ github.workflow }}-${{ github.event.sha }}-${{ github.event.target_url }}` for GHA/appveyor-status. - `group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}` for all the rest. Ref: https://github.com/curl/curl/actions/runs/18776245057/job/53571438139?pr=19209 Closes #19215
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unifies the following http3 workflows into http3-linux.yml:
The idea is better use of the build cache. Previously, they independently create caches with the same key. Some of the caches include source code and intermediate object files, which makes cache quite large. In this commit, only built artifacts are cached, which drastically reduces the cache size. OpenSSL v3, mod_h2 and quiche caches still include all stuff, but they are left for the later improvement. Because the contents of the cache have been changed, the cache keys are also changed to include the word "http3".