cmake: allow ENABLE_CURLDEBUG=OFF with ENABLE_DEBUG=ON#13792
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
cmake: allow ENABLE_CURLDEBUG=OFF with ENABLE_DEBUG=ON#13792vszakats wants to merge 4 commits intocurl:masterfrom
ENABLE_CURLDEBUG=OFF with ENABLE_DEBUG=ON#13792vszakats wants to merge 4 commits intocurl:masterfrom
Conversation
Before this patch, `ENABLE_CURLDEBUG` (memory tracking) was unconditionally enabled when `ENABLE_DEBUGBUILD` was set. This made testing some build configurations complicated. To fix this, after this patch we only enable `ENABLE_CURLDEBUG` if not already defined by the user. This allows to use this config: ENABLE_DEBUGBUILD=ON ENABLE_CURLDEBUG=OFF to enable debug features, without also enabling memory tracking. This is important because some other build methods allow to set one of these features but not the other. This patch allows to test any combination with CMake. This makes it unnecessary to use the workaround of passing `-DDEBUGBUILD` via `CMAKE_C_FLAGS`. Which has the disadvantage that our CMake logic cannot easily detect it, e.g. for disabling symbol hiding on Windows for `ENABLE_DEBUG`/`DEBUGBUILD` builds. Cherry-picked from curl#13718 Closes #xxxxx
e790429 to
c53a2d0
Compare
ENABLE_CURLDEBUG with ENABLE_DEBUG=ONENABLE_CURLDEBUG=OFF with ENABLE_DEBUG=ON
This reverts commit c53a2d0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch,
ENABLE_CURLDEBUG(memory tracking) wasunconditionally enabled when
ENABLE_DEBUGBUILDwas set. This madetesting some build configurations complicated. To fix it, this patch
makes
ENABLE_CURLDEBUGto receive the value ofENABLE_DEBUGbydefault, while allowing free override by the user.
This allows to use the config:
ENABLE_DEBUGBUILD=ON ENABLE_CURLDEBUG=OFFto enable debug features, without also enabling memory tracking.
This is important because some other build methods allow to set one of
these features but not the other. This patch allows to test any
combination with CMake.
This makes it unnecessary to use the workaround of passing
-DDEBUGBUILDviaCMAKE_C_FLAGS. Which has the disadvantage that ourCMake logic cannot easily detect it, e.g. for disabling symbol hiding on
Windows for
ENABLE_DEBUG/DEBUGBUILDbuilds.Cherry-picked from #13718
Closes #13792