GHA: add three old (gcc 6, 7, 9) mingw-w64 jobs#13759
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
GHA: add three old (gcc 6, 7, 9) mingw-w64 jobs#13759vszakats wants to merge 2 commits intocurl:masterfrom
vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
45ef829 to
8c06af0
Compare
12fca29 to
9a3ee70
Compare
6 tasks
9a3ee70 to
4813950
Compare
4813950 to
ab8d437
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
May 28, 2024
These exclusions came from the AppVeyor CI config, but they do pass now and they are static tests with no flakiness risk. Follow-up to 0914d8a curl#13759 Closes #xxxxx
vszakats
added a commit
that referenced
this pull request
Jun 2, 2024
- stop altering the `PATH` via `GITHUB_ENV`. This confused the `actions/cache` post-job, which needs to run in the exact same environment as its pre-job, to have a consistent cache entry "version" hash. Altering the `PATH` via `GITHUB_ENV` spills into the the post-job and breaks this hash. GHA doesn't reset the env automatically and I have not found a way to do it manually. - add double-quotes where missing. - move cache directory under `USERPROFILE` to not rely on absolute paths. - make cache directory flatter and versionless. Follow-up to 0914d8a #13759 Closes #13856
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implement old mingw-w64 jobs in GHA. This allows to use the latest
Windows runners, replacing Windows Server 2012 R2 (gcc 6) and Windows
Server 2016 (gcc 7, 9) with Windows Server 2022.
GHA runners are also significantly faster, and allow running tests in
parallel (
-j14). It also offloads 3 more long-running jobs fromAppVeyor CI.
These jobs download (then cache) the mingw-w64 packages from their
original location, which allows flexibility in choosing which versions
and flavours (win32/POSIX, SEH/DWARF, 64/32-bit) we want to test in CI.
The new jobs use these distros:
I matched existing AppVeyor job configs, with these differences:
(same distro as on AppVeyor, but the latest bugfix release)
(in AppVeyor this relies on an old MSYS2 pre-installed on the runner)
I did not replicate existing test exclusions, and oddly enough the few
failures (so far) were different from MSYS2 jobs and also from their
AppVeyor CI counterparts.
Also:
-uoption fromcygpathcalls.TFLAGS-acoption.(it's available in modern runners.)
SYSTEMROOToverWINDIR.Job performance:
Based on these runs:
https://ci.appveyor.com/project/curlorg/curl/builds/49880799
https://github.com/curl/curl/actions/runs/9218292508
Notice that building examples and tests is time consuming.
We can tweak any build parameter as necessary to make them more useful
and/or without clogging the job queue or introducing flakiness.
Closes #13759
path:must use Windows path notation. Not even~works, despite the documentation and apparently all cache examples are meant for *nix runners.]