cmake: initialize BUILD_TESTING before first use#13668
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: initialize BUILD_TESTING before first use#13668vszakats wants to merge 1 commit intocurl:masterfrom
BUILD_TESTING before first use#13668vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
Before this patch `BUILD_TESTING` was used once, then initialized, then used again. This caused the `curlu` library not being built when relying on an implicit `BUILD_TESTING=ON` setting, and ending up with a link error when building the `testdeps` target. It did not cause issues when `BUILD_TESTING` was explicitly set. Move the initialization before the first use to fix it. Closes #xxxxx
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch
BUILD_TESTINGwas used once, then initialized, thenused again. This caused the
curlulibrary not being built when relyingon an implicit
BUILD_TESTING=ONsetting, and ending up with a linkerror when building the
testdepstarget.It did not cause issues when
BUILD_TESTINGwas explicitly set.Move the initialization before the first use to fix it.
Regression from aace27b #12287
Closes #13668