appveyor: guard against crash-build with VS2008#13654
Closed
vszakats wants to merge 4 commits intocurl:masterfrom
Closed
appveyor: guard against crash-build with VS2008#13654vszakats wants to merge 4 commits intocurl:masterfrom
vszakats wants to merge 4 commits intocurl:masterfrom
Conversation
5 tasks
This reverts commit c94349f. They aren't affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combination of
-DDEBUGBUILD, a sharedcurl.exe, and the VS2008compiler creates a
curl.exesegfaulting on startup:Ref: https://ci.appveyor.com/project/curlorg/curl/builds/49817266/job/651iy6qn1e238pqj#L191
Add job that triggers the issue and add the necessary logic to skip
running the affected
curl.exe.Ref: #13592
Closes #13654
Fixing the actual problem would be nicer, but it would require a local
environment like the affected one and a will/need to track this down.