cmake: fix CURL_WERROR=ON for old CMake and use it in GHA/linux-old#13282
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
cmake: fix CURL_WERROR=ON for old CMake and use it in GHA/linux-old#13282vszakats wants to merge 2 commits intocurl:masterfrom
CURL_WERROR=ON for old CMake and use it in GHA/linux-old#13282vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
c4159da to
ae8614c
Compare
9b5cd26 to
eae006c
Compare
-pedentic-errors preconditions, set CURL_WERROR=ON for GHA/linux-old
-pedentic-errors preconditions, set CURL_WERROR=ON for GHA/linux-old-pedantic-errors preconditions, set CURL_WERROR=ON for GHA/linux-old
eae006c to
e460e39
Compare
-pedantic-errors preconditions, set CURL_WERROR=ON for GHA/linux-old-pedantic-errors conditions, set CURL_WERROR=ON for GHA/linux-old
0b904e8 to
491fcb4
Compare
-pedantic-errors conditions, set CURL_WERROR=ON for GHA/linux-old-pedantic-errors for old CMake, set CURL_WERROR=ON on GHA/linux-old
-pedantic-errors for old CMake, set CURL_WERROR=ON on GHA/linux-oldCURL_WERROR=ON for old CMake and use it in GHA/linux-old
`-pedantic-errors` option throws a warning with GCC (all versions) in `check_symbol_exists()`, which makes feature checks fail. CMake v3.23.0 (2022-03-29) introduced a workaround: https://gitlab.kitware.com/cmake/cmake/-/issues/13208 https://gitlab.kitware.com/cmake/cmake/-/commit/eeb45401163d831b8c841ef6eba81466b4067b68 https://gitlab.kitware.com/cmake/cmake/-/commit/1ab7c3cd28b27ca162c4559e1026e5cad1898ade Make sure to not enable this option for CMake versions older than that. Follow-up to 3829759 curl#12489
491fcb4 to
d032bdc
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake: fix
-pedantic-errorsfor old CMake withCURL_WERROR=ONset.-pedantic-errorsoption throws a warning with GCC (all versions) andmakes
check_symbol_exists()fail in CMake versions older thanv3.23.0 (2022-03-29), when CMake introduced a workaround:
https://gitlab.kitware.com/cmake/cmake/-/issues/13208
https://gitlab.kitware.com/cmake/cmake/-/commit/eeb45401163d831b8c841ef6eba81466b4067b68
https://gitlab.kitware.com/cmake/cmake/-/commit/1ab7c3cd28b27ca162c4559e1026e5cad1898ade
Follow-up to 3829759 build: enable missing OpenSSF-recommended warnings, with fixes #12489
set
CURL_WERROR=ONfor thelinux-oldjob in CI.Closes #13282