GHA: adjust parallel job counts#12927
GHA: adjust parallel job counts#12927Ayesh wants to merge 1 commit intocurl:masterfrom Ayesh:ci-make-parallel/ci
Conversation
|
Why not using |
|
The root level We could setup the env var before calling |
|
See PR #11510. This hasn't been enabled already because of reliability issues
on the CI systems. But, there have been a few issues fixed since I tried last,
so it will be interesting to see CI results of this PR.
|
|
Thank you @dfandrich - I saw your commit that added parallel CI jobs and the discussions around it. GitHub recently doubled the specs of their hosted runners, so this one tries to take advantage of it. I could run this locally with |
|
@dfandrich so do we close this as a duplicate of #11510 ? |
Adjusts the `make -j` flag to match the latest GitHub-hosted runner hardware specs[^1]: - `ubuntu-latest` on 4 CPU cores - `macos-latest` on 3 CPU cores The processor count is ideally obtained from `nproc`, but setting env vars from the current CI yaml files is not possible because they expect literal strings. [^1]: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories Closes #12927
|
This is independent from the test parallelism. But bumping build parallelism as in this PR, did not seem to bring a conclusive improvement according to the few test runs seen today. Ref: #13807 and https://github.com/curl/curl-for-win/actions/runs/9265348474. Not sure why. |
|
Sorry, I missed responding to the comment but more importantly missed that this was adjusting build jobs and not test jobs. This change should be conceptually fine. I've found that GHA machines can be a bit overloaded sometimes, so I could see how increasing the number of build processes might not always reduce the build time, but it should probably be done anyway to take advantage of times of low load. |
Agreed. |
|
Thank you @Ayesh, merged now! |
Follow-up to e838b34 curl#12927 Closes curl#13807
Adjusts the
make -jflag to match the latest GitHub-hosted runnerhardware specs1:
ubuntu-lateston 4 CPU coresmacos-lateston 3 CPU coresThe processor count is ideally obtained from
nproc, but setting envvars from the current CI yaml files is not possible because they expect
literal strings.
Closes #12927
Footnotes
https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories ↩