build: fix -Wconversion/-Wsign-conversion warnings#12557
Closed
vszakats wants to merge 3 commits intocurl:masterfrom
Closed
build: fix -Wconversion/-Wsign-conversion warnings#12557vszakats wants to merge 3 commits intocurl:masterfrom
-Wconversion/-Wsign-conversion warnings#12557vszakats wants to merge 3 commits intocurl:masterfrom
Conversation
-Wconversion warning
The hope is that this fixes the FD_SET() type misalignment, that
is present in MSYS but not in Cygwin builds:
```
../../../docs/examples/sendrecv.c:47:3: warning: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Wsign-conversion]
47 | FD_SET(sockfd, &errfd); /* always check for error */
| ^~~~~~
```
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/48794906/job/54616tw3d74xrf6o?fullLog=true#L3031
This has been fixed in Cygwin in mid-2020:
https://cygwin.com/git/?p=newlib-cygwin.git;a=commitdiff;h=5717262b8ecfed0f7fab63e2c09c78991e36f9dd
-Wconversion warning-Wconversion/-Wsign-conversion warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix remaining warnings in examples and tests which are not suppressed
by the pragma in
lib/curl_setup.h.Silence a toolchain issue causing warnings in
FD_SET()calls witholder Cygwin/MSYS2 builds. Likely fixed on 2020-08-03 by:
https://cygwin.com/git/?p=newlib-cygwin.git;a=commitdiff;h=5717262b8ecfed0f7fab63e2c09c78991e36f9dd
Follow-up to 2dbe75b #12492
Closes #12557
Red CI after merging to master: https://ci.appveyor.com/project/curlorg/curl/builds/48791215
Edit: The last CI run for the PR skipped the AppVeyor tests, which were not clean yet apparently.