Skip to content

build: add src/.checksrc to source tarball#12085

Closed
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:src-checksrc-extra-dist
Closed

build: add src/.checksrc to source tarball#12085
vszakats wants to merge 1 commit intocurl:masterfrom
vszakats:src-checksrc-extra-dist

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Oct 11, 2023

Regression from e5bb88b #11958

Bug: #11958 (comment)
Reported-by: Romain Geissler
Fixes #12084
Closes #12085

Regression from e5bb88b curl#11958

Bug: curl#11958 (comment)
Reported-by: Romain Geissler
Closes #xxxxx
@Romain-Geissler-1A
Copy link
Contributor

Ah thanks ! I also reported it as #12084.

@MarcelRaad
Copy link
Member

Ah, that's also visible in the autobuilds. We need to look at them more :-(

@vszakats
Copy link
Member Author

@MarcelRaad: Can we make that test fail if it detects a distcheck issue?

@MarcelRaad
Copy link
Member

I'm not familiar with the packaging process, unfortunately. Probably @bagder can answer that? We have that issue quite regularly, so that would be great.

@vszakats
Copy link
Member Author

vszakats commented Oct 11, 2023

Unless I'm missing something, we might miss a make distcheck
in the distcheck GHA. It needs to be an out-of-tree build to catch
this (and cover dot files, which it probably does?). This needs to
be tested in practice. Existing tests try to build from a freshly made
source tarball, but one of them is CMake, which doesn't run checksrc
on its own to catch this particular case, the other is autotools, which
is likely not a debug build to break on this either.

I'm testing this in #12088.

@vszakats vszakats closed this in fac90bd Oct 11, 2023
@vszakats vszakats deleted the src-checksrc-extra-dist branch October 11, 2023 14:05
@vszakats vszakats added the tests label Oct 11, 2023
vszakats added a commit that referenced this pull request Oct 12, 2023
Add a job that builds curl from a generated source tarball sample, with
autotools, out-of-tree, in debug mode.

Ref: #12085
Closes #12088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Curl 8.4.0 fails to build because of a checksrc error. File src/.checksrc is missing from release tarball

3 participants