autotools: restore HAVE_IOCTL_* detections#12008
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
autotools: restore HAVE_IOCTL_* detections#12008vszakats wants to merge 1 commit intocurl:masterfrom
HAVE_IOCTL_* detections#12008vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
This restores `CURL_CHECK_FUNC_IOCTL` detection. I deleted it in 4d73854 and c345665 (2022-08), because the `HAVE_IOCTL` result it generated was unused in the source. But, I missed the fact that this had two dependent checks: `CURL_CHECK_FUNC_IOCTL_FIONBIO`, `CURL_CHECK_FUNC_IOCTL_SIOCGIFADDR` that we do actually need: `HAVE_IOCTL_FIONBIO`, `HAVE_IOCTL_SIOCGIFADDR`. Ref: curl#11964 (effort to sync cmake detections with autotools) Closes #xxxxx
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores
CURL_CHECK_FUNC_IOCTLdetection. I deleted it in4d73854 and c345665 (2022-08), because the
HAVE_IOCTLresult it generated was unused in the source. But,
I did miss the fact that this had two dependent checks:
CURL_CHECK_FUNC_IOCTL_FIONBIO,CURL_CHECK_FUNC_IOCTL_SIOCGIFADDRthat we do actually need:HAVE_IOCTL_FIONBIO,HAVE_IOCTL_SIOCGIFADDR.Regression from 4d73854
Ref: #11964 (effort to sync cmake detections with autotools)
Closes #12008