Skip to content

cmake: fix HAVE_WRITABLE_ARGV detection#11978

Closed
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:fix-HAVE_WRITABLE_ARGV
Closed

cmake: fix HAVE_WRITABLE_ARGV detection#11978
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:fix-HAVE_WRITABLE_ARGV

Conversation

@vszakats
Copy link
Member

@vszakats vszakats commented Sep 28, 2023

Move detection before the creation of detection results in
curl_config.h.

Ref: #11964 (effort to sync cmake detections with autotools)

Closes #11978

Move detection before the creation of detection results
in `curl_config.h`.

Ref: curl#11964

Closes #xxxxx
@jay
Copy link
Member

jay commented Sep 29, 2023

I suggest add a sentence why you're making the change, for example

Move detection before the creation of detection results
in `curl_config.h`.

This change is part of the effort to sync cmake and autotools output.

Ref: #11964

Closes #xxxxx

@vszakats vszakats closed this in ca7daad Sep 29, 2023
@vszakats vszakats deleted the fix-HAVE_WRITABLE_ARGV branch September 29, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants