cmake, configure: Also link with CoreServices#11894
Closed
ryandesign wants to merge 1 commit intocurl:masterfrom
Closed
cmake, configure: Also link with CoreServices#11894ryandesign wants to merge 1 commit intocurl:masterfrom
ryandesign wants to merge 1 commit intocurl:masterfrom
Conversation
When linking with CoreFoundation, also link with CoreServices which is apparently required to avoid an NSInvalidArgumentException in software linking with libcurl on macOS Sonoma 14 and later. Fixes curl#11893
bagder
approved these changes
Sep 20, 2023
Member
|
Thanks! |
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
When linking with CoreFoundation, also link with CoreServices which is apparently required to avoid an NSInvalidArgumentException in software linking with libcurl on macOS Sonoma 14 and later. Fixes curl#11893 Closes curl#11894
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linking with CoreFoundation, also link with CoreServices which is apparently required to avoid an NSInvalidArgumentException in software linking with libcurl on macOS Sonoma 14 and later.
Fixes #11893
I am running macOS Monterey 12 so I have not verified that this fixes the crash, though others claim that it does, and I have verified that this does cause libcurl.dylib to link with CoreServices using either the autotools or cmake build systems.
CoreServices is available on every version of macOS and dynamically linked libraries aren't loaded in unless their functions are actually used at runtime, so linking with this framework even on earlier macOS versions where it wasn't needed shouldn't cause any problems.