Closed
Conversation
Contributor
icing
commented
Jul 10, 2023
- TARGET_OS_OSX is not always defined on macOS
- this leads to missing symbol Curl_macos_init()
- TargetConditionals.h seems to define these only when dynamic targets are enabled (somewhere?)
- this PR fixes that on my macOS 13.4.1
- I have no clue why CI builds worked without it
- TARGET_OS_OSX is not always defined on macOS - this leads to missing symbol Curl_macos_init() - TargetConditionals.h seems to define these only when dynamic targets are enabled (somewhere?) - this PR fixes that on my macOS 13.4.1 - I have no clue why CI builds worked without it
Member
|
Thanks! |
bch
pushed a commit
to bch/curl
that referenced
this pull request
Jul 19, 2023
- TARGET_OS_OSX is not always defined on macOS - this leads to missing symbol Curl_macos_init() - TargetConditionals.h seems to define these only when dynamic targets are enabled (somewhere?) - this PR fixes that on my macOS 13.4.1 - I have no clue why CI builds worked without it Follow-up to c730859 Closes curl#11417
ptitSeb
pushed a commit
to wasix-org/curl
that referenced
this pull request
Sep 25, 2023
- TARGET_OS_OSX is not always defined on macOS - this leads to missing symbol Curl_macos_init() - TargetConditionals.h seems to define these only when dynamic targets are enabled (somewhere?) - this PR fixes that on my macOS 13.4.1 - I have no clue why CI builds worked without it Follow-up to c730859 Closes curl#11417
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.