Skip to content

Fix Flags not to allow setters#8104

Merged
emcastillo merged 2 commits intocupy:mainfrom
asi1024:fix-flags
Jan 24, 2024
Merged

Fix Flags not to allow setters#8104
emcastillo merged 2 commits intocupy:mainfrom
asi1024:fix-flags

Conversation

@asi1024
Copy link
Copy Markdown
Member

@asi1024 asi1024 commented Jan 11, 2024 

>>> import numpy
>>> x = numpy.array([1, 2, 3])
>>> x.flags.c_contiguous = True
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: attribute 'c_contiguous' of 'numpy.core.multiarray.flagsobj' objects is not writable

@emcastillo emcastillo self-assigned this Jan 12, 2024
@emcastillo emcastillo added cat:enhancement Improvements to existing features prio:medium labels Jan 12, 2024
@emcastillo emcastillo added this to the v14.0.0a1 milestone Jan 12, 2024
@emcastillo emcastillo added cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch and removed cat:enhancement Improvements to existing features labels Jan 12, 2024
@asi1024 asi1024 mentioned this pull request Jan 17, 2024
Open
@asi1024
Copy link
Copy Markdown
Member Author

asi1024 commented Jan 18, 2024

/test mini

@emcastillo emcastillo merged commit 710257a into cupy:main Jan 24, 2024
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Jan 24, 2024
@chainer-ci
Merge pull request cupy#8104 from asi1024/fix-flags
ffd66ff 
Fix Flags not to allow setters
@chainer-ci chainer-ci mentioned this pull request Jan 24, 2024
Merged
@asi1024 asi1024 deleted the fix-flags branch January 24, 2024 08:04
@kmaehashi kmaehashi mentioned this pull request Aug 22, 2024
Merged
@kmaehashi kmaehashi mentioned this pull request Feb 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Jun 26, 2025
Merged
@kmaehashi kmaehashi mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

+1 more reviewer

@emcastillo emcastillo emcastillo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emcastillo emcastillo

Labels

cat:bug Bugs prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v14.0.0a1

Development

Successfully merging this pull request may close these issues.

3 participants

@asi1024 @leofang @emcastillo