Skip to content

Update for deprecations in NumPy 1.24#7245

Merged
emcastillo merged 6 commits intocupy:masterfrom
kmaehashi:numpy-1.24-deprecations
Dec 21, 2022
Merged

Update for deprecations in NumPy 1.24#7245
emcastillo merged 6 commits intocupy:masterfrom
kmaehashi:numpy-1.24-deprecations

Conversation

@kmaehashi
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi commented Dec 19, 2022 •
edited
Loading

Refs #7243

https://numpy.org/devdocs/release/1.24.0-notes.html

Deprecated in NumPy 1.24:

  • Deprecate msort
  • np.str0 and similar are now deprecated

Expired deprecations in NumPy 1.24:

  • The deprecation for the aliases np.object, np.bool, np.float, np.complex, np.str, and np.int is expired (introduces NumPy 1.20). Some of these will now give a FutureWarning in addition to raising an error since they will be mapped to the NumPy scalars in the future.

@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Dec 19, 2022

/test mini

@kmaehashi kmaehashi mentioned this pull request Dec 19, 2022
Merged
@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Dec 19, 2022

/test head

@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Dec 19, 2022

/test mini,head

@kmaehashi kmaehashi added cat:numpy-compat Follow the NumPy/SciPy spec changes prio:high to-be-backported Pull-requests to be backported to stable branch labels Dec 20, 2022
@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Dec 20, 2022

/test mini

@kmaehashi kmaehashi mentioned this pull request Dec 20, 2022
Closed
8 tasks
emcastillo
emcastillo approved these changes Dec 21, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcastillo emcastillo merged commit 0f968f9 into cupy:master Dec 21, 2022
@emcastillo emcastillo added this to the v12.0.0b3 milestone Dec 21, 2022
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 21, 2022

@emcastillo Failed to backport automatically.

Not cleanly cherry-picked

@kmaehashi kmaehashi deleted the numpy-1.24-deprecations branch December 22, 2022 14:06
kmaehashi pushed a commit to kmaehashi/cupy that referenced this pull request Dec 22, 2022
@kmaehashi
Merge pull request cupy#7245 from kmaehashi/numpy-1.24-deprecations
aeaaf06 
Update for deprecations in NumPy 1.24
@kmaehashi kmaehashi mentioned this pull request Dec 22, 2022
Merged
This was referenced Jan 12, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@emcastillo emcastillo emcastillo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emcastillo emcastillo

Labels

cat:numpy-compat Follow the NumPy/SciPy spec changes prio:high to-be-backported Pull-requests to be backported to stable branch

Projects

Platform Support (CZI EOSS 5)
Status: ✅ Done

Milestone

v12.0.0b3

Development

Successfully merging this pull request may close these issues.

3 participants

@kmaehashi @chainer-ci @emcastillo