Skip to content

Support all advanced indexing#6127

Merged
asi1024 merged 9 commits intocupy:masterfrom
toslunar:getitem-masks
Dec 2, 2021
Merged

Support all advanced indexing#6127
asi1024 merged 9 commits intocupy:masterfrom
toslunar:getitem-masks

Conversation

@toslunar
Copy link
Copy Markdown
Member

In __getitem__, __setitem__, and scatter ops, allow mask index to be combined with other masks or arrays.

@toslunar toslunar added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch labels Nov 18, 2021
@toslunar
Copy link
Copy Markdown
Member Author

/test mini

@toslunar
Copy link
Copy Markdown
Member Author

Shape of masks should be checked. For example, cupy.arange(12).reshape(3, 4)[[1, 0], [True, True]] should raise IndexError.

>>> numpy.arange(12).reshape(3, 4)[[1, 0], [True, True]]
IndexError: boolean index did not match indexed array along dimension 1; dimension is 4 but corresponding boolean dimension is 2

@toslunar toslunar added the st:awaiting-author Awaiting response from author label Nov 19, 2021
@toslunar toslunar removed the st:awaiting-author Awaiting response from author label Nov 22, 2021
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Nov 29, 2021

Jenkins, test this please.

@toslunar
Copy link
Copy Markdown
Member Author

toslunar commented Dec 2, 2021

Updated the branch because it seems CI config has been updated.

@toslunar
Copy link
Copy Markdown
Member Author

toslunar commented Dec 2, 2021

/test mini

@toslunar toslunar requested a review from asi1024 December 2, 2021 06:47
@asi1024 asi1024 added this to the v11.0.0a1 milestone Dec 2, 2021
@asi1024 asi1024 merged commit eb71024 into cupy:master Dec 2, 2021
chainer-ci pushed a commit to chainer-ci/cupy that referenced this pull request Dec 2, 2021
@toslunar toslunar deleted the getitem-masks branch December 2, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:enhancement Improvements to existing features prio:medium to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants