Skip to content

[MNT] Add short comments for the internals#3475

Merged
asi1024 merged 1 commit intocupy:masterfrom
leofang:internal_doc
Jun 25, 2020
Merged

[MNT] Add short comments for the internals#3475
asi1024 merged 1 commit intocupy:masterfrom
leofang:internal_doc

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Jun 23, 2020

Close #2522.

Related: #2449, #2518, #2731 (comment).

@kmaehashi kmaehashi added the cat:code-fix Code refactoring that do not change behavior label Jun 24, 2020
@kmaehashi kmaehashi added this to the v8.0.0b5 milestone Jun 24, 2020
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Jun 24, 2020

Jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit bba2f4c:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit bba2f4c, target branch master) succeeded!

@emcastillo emcastillo modified the milestone: v8.0.0b5 Jun 25, 2020
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Jun 25, 2020

LGTM.

@asi1024 asi1024 merged commit eaa02ef into cupy:master Jun 25, 2020
@leofang leofang deleted the internal_doc branch June 25, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:code-fix Code refactoring that do not change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document _J in reduction kernel template

6 participants