Remove unused variable from _get_simple_reduction_kernel template#2518
Closed
grlee77 wants to merge 1 commit intocupy:masterfrom
Closed
Remove unused variable from _get_simple_reduction_kernel template#2518grlee77 wants to merge 1 commit intocupy:masterfrom
_get_simple_reduction_kernel template#2518grlee77 wants to merge 1 commit intocupy:masterfrom
Conversation
Member
|
Jenkins, test this please |
Collaborator
|
Successfully created a job for commit 653d6ea: |
_get_simple_reduction_kernel template
Member
|
It seems it's actually used in |
Member
|
Jenkins CI test (for commit 653d6ea, target branch master) failed with status FAILURE. |
Member
Author
|
Okay, my mistake. I will close this one. Thanks |
Member
|
Thank you any way for reporting. |
Member
|
Haha it happens. Like in #2449 I thought I caught two unused lines, but it turned out that they are needed to keep the objects alive. There're always surprises. But, it's nice to have additional pairs of eyes inspecting the codebase. One day we'll catch a real one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_Jis defined and incremented, but doesn't appear to actually ever be used