Skip to content

Fix test_helper.py for NumPy 1.18#2883

Merged
emcastillo merged 1 commit intocupy:masterfrom
niboshi:test-helper-numpy-1-18
Jan 6, 2020
Merged

Fix test_helper.py for NumPy 1.18#2883
emcastillo merged 1 commit intocupy:masterfrom
niboshi:test-helper-numpy-1-18

Conversation

@niboshi
Copy link
Copy Markdown
Member

@niboshi niboshi commented Dec 25, 2019

Error message was changed in 1.18.
I think error message can be simply ignored.

@niboshi niboshi added cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch labels Dec 25, 2019
@kmaehashi kmaehashi self-assigned this Dec 26, 2019
@emcastillo
Copy link
Copy Markdown
Member

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit f29e6df:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit f29e6df, target branch master) succeeded!

Copy link
Copy Markdown
Member

@emcastillo emcastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emcastillo emcastillo merged commit 5a582d6 into cupy:master Jan 6, 2020
@niboshi niboshi deleted the test-helper-numpy-1-18 branch January 6, 2020 05:38
@chainer-ci
Copy link
Copy Markdown
Member

@emcastillo This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

emcastillo pushed a commit to emcastillo/cupy that referenced this pull request Jan 7, 2020
emcastillo pushed a commit to emcastillo/cupy that referenced this pull request Jan 7, 2020
@asi1024 asi1024 added this to the v8.0.0a1 milestone Jan 16, 2020
@toslunar toslunar mentioned this pull request Jan 21, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:test Test code / CI to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants