Fix argmin/argmax dtype argument#2872
Merged
emcastillo merged 3 commits intocupy:masterfrom Dec 26, 2019
Merged
Conversation
9b6475d to
158ac6a
Compare
leofang
reviewed
Dec 24, 2019
cupy/core/_routines_statistics.pyx
Outdated
| ('d->q', (None, 'my_argmin_float(a, b)', None, None)), | ||
| ('F->q', (None, 'my_argmin_float(a, b)', None, None)), | ||
| ('D->q', (None, 'my_argmin_float(a, b)', None, None))), | ||
| tuple(['{}->{}'.format(d, r) for r in 'bhilq' for d in '?BhHiIlLqQ']) |
Member
There was a problem hiding this comment.
I am a bit concerned with the order 'bhilq'. Which return type is chosen when argmin(..., dtype=None, ...) is called? I thought we'd need to put 'q' as the leading character to match NumPy default, but I could be wrong. (I don't have access now to test this PR.)
Member
Author
There was a problem hiding this comment.
Thank you for pointing out! It seems you are correct. Some of the tests were failing.
Fixed in eb90e95.
Member
|
To close #2595, it'd be nice to document the API deviation (which is a good thing I think). |
Member
|
Waiting till #2870 is merged |
Member
Author
|
#2870 merged. |
Member
|
Jenkins, test this please |
Collaborator
|
Successfully created a job for commit ecb3e72: |
Member
|
Jenkins CI test (for commit ecb3e72, target branch master) succeeded! |
emcastillo
pushed a commit
to emcastillo/cupy
that referenced
this pull request
Dec 26, 2019
Fix `argmin`/`argmax` `dtype` argument
emcastillo
pushed a commit
to emcastillo/cupy
that referenced
this pull request
Dec 26, 2019
Fix `argmin`/`argmax` `dtype` argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2595
Requires #2870