Skip to content

Do not let Python 2 users build CuPy v7+#2766

Merged
mergify[bot] merged 3 commits intocupy:masterfrom
leofang:patch-1
Feb 6, 2020
Merged

Do not let Python 2 users build CuPy v7+#2766
mergify[bot] merged 3 commits intocupy:masterfrom
leofang:patch-1

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Dec 5, 2019

Close #2763.

cc: @JanuszL

@leofang leofang mentioned this pull request Dec 5, 2019
Closed
@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Dec 5, 2019

Could you use python_requires='>=3.5.0'? (chainer/chainer#7936) Then pip prints error message on unsupported Python:

cupy requires Python '>=3.5.0' but the running Python is 2.7.14

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Dec 5, 2019 •
edited
Loading

Sounds good, thanks @kmaehashi. PTAL.

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Dec 5, 2019

@kmaehashi Travis still tests PY34...Should I lower the requirement a bit?

@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Dec 5, 2019

Thanks for doing this @leofang! 😄

@jakirkham
Copy link
Copy Markdown
Member

jakirkham commented Dec 5, 2019

@kmaehashi Travis still tests PY34...Should I lower the requirement a bit?

If so, we might want to add Python 3.4 to the trove classifiers.

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Dec 6, 2019

If so, we might want to add Python 3.4 to the trove classifiers.

and also the installation guide.

This was referenced Dec 12, 2019
Merged
Merged
@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Dec 24, 2019

pfnCI, test this please.
(Let's ignore travis failure in 3.4.)

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Dec 24, 2019

Successfully created a job for commit 8093b63:

@kmaehashi kmaehashi added cat:install Build and installation to-be-backported Pull-requests to be backported to stable branch labels Dec 24, 2019
@kmaehashi kmaehashi added this to the v8.0.0a1 milestone Dec 24, 2019
@kmaehashi kmaehashi changed the title Do not let Python 2 users build CuPy v7 Do not let Python 2 users build CuPy v7+ Dec 24, 2019
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 24, 2019

Jenkins CI test (for commit 8093b63, target branch master) succeeded!

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Jan 10, 2020

@kmaehashi Looks like this passed the CI?

@leofang
Copy link
Copy Markdown
Member Author

leofang commented Jan 10, 2020

I removed the Python 2 warning in d9775d7 since it won't even build for PY2.

@leofang leofang mentioned this pull request Jan 22, 2020
Closed
@kmaehashi kmaehashi mentioned this pull request Feb 6, 2020
Merged
@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Feb 6, 2020

pfnCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Feb 6, 2020

Successfully created a job for commit d9775d7:

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Feb 6, 2020
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Feb 6, 2020

Jenkins CI test (for commit d9775d7, target branch master) succeeded!

@mergify mergify bot merged commit 5696813 into cupy:master Feb 6, 2020
kmaehashi pushed a commit to kmaehashi/cupy that referenced this pull request Feb 6, 2020
@mergify @kmaehashi
Merge pull request cupy#2766 from leofang/patch-1
4c53c5b 
Do not let Python 2 users build CuPy v7+
@kmaehashi kmaehashi mentioned this pull request Feb 6, 2020
Merged
@leofang leofang deleted the patch-1 branch February 6, 2020 13:03
grlee77 added a commit to grlee77/cupy that referenced this pull request Feb 7, 2020
@grlee77
Merge remote-tracking branch 'upstream/master' into grl_dev
13fc410 
* upstream/master:
  apply cupy#2919 (comment)
  Fix nvcc command lookup
  Add NumPy 1.18 to installation guide
  Use (1, 3)-shape to specify RGB
  Use `scipy.stats` to compute bivariate normal
  Fix setup.py
  Keep imag a view of original array
  Print installed packages in pytest
  Fix typos in comments
  defaults to in-place scan
  avoid using cub_scan for complex128; simplify shape
  Remove PY2 warning
  Add CUDA 10.2 support
  Remove TODO
  Fix imag for 0-size array
  Apply cupy#2766 (comment)
  Do not let Python 2 users build CuPy v7
  Fix flake8
  Use intptr_t for cusolver handler
@pazeshun pazeshun mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JanuszL JanuszL JanuszL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kmaehashi kmaehashi

Labels

cat:install Build and installation st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v8.0.0a1

Development

Successfully merging this pull request may close these issues.

CUPY 7.0 fails with Python 2.7

6 participants

@leofang @kmaehashi @jakirkham @pfn-ci-bot @chainer-ci @JanuszL