Conversation
bfcbc62 to
eca27aa
Compare
eca27aa to
8827a08
Compare
|
PTAL. |
|
This is good PR. |
cupy/core/reduction.pxi
Outdated
| out_block_num * block_size, inout_args, 0, block_size, stream) | ||
| return ret | ||
|
|
||
| cpdef _get_expressions_and_types(self, in_args, out_args, dtype): |
There was a problem hiding this comment.
Why not support them as cdef methods and write argument types explicitly?
There was a problem hiding this comment.
cdef methods cannot be overridden.
dtype argument does not have a specific type.
There was a problem hiding this comment.
Do you mean other arguments?
I doubt typing tuples improves performance. I'll check.
There was a problem hiding this comment.
I only observe difference of 1-2 ns. I think it's negligible.
Co-Authored-By: Akifumi Imanishi <akifumi.imanishi@gmail.com>
Co-Authored-By: Ryosuke Okuta <okuta@preferred.jp>
|
Jenkins, test this please. |
|
Successfully created a job for commit 1248a78: |
1248a78 to
79793ee
Compare
|
Force-pushed a fix to remove an incorrect typing to |
|
Jenkins, test this please. |
|
Successfully created a job for commit 79793ee: |
|
Jenkins CI test (for commit 1248a78, target branch master) failed with status FAILURE. |
|
Jenkins CI test (for commit 79793ee, target branch master) failed with status FAILURE. |
aecac39 to
16be409
Compare
|
Conflict resolved. |
|
Jenkins, test this please. |
|
Successfully created a job for commit 16be409: |
|
Jenkins CI test (for commit 16be409, target branch master) failed with status FAILURE. |
|
Fixed test failure. |
|
Jenkins, test this please. |
|
Successfully created a job for commit 07778d9: |
|
Jenkins CI test (for commit 07778d9, target branch master) succeeded! |
|
LGTM. |
Merges the logic of
ReductionKernelandsimple_reduction_function.