Skip to content

Improve reduction core#2697

Merged
asi1024 merged 5 commits intocupy:masterfrom
okuta:improve-reduction-core
Dec 3, 2019
Merged

Improve reduction core#2697
asi1024 merged 5 commits intocupy:masterfrom
okuta:improve-reduction-core

Conversation

@okuta
Copy link
Copy Markdown
Member

@okuta okuta commented Nov 24, 2019 •
edited
Loading

This PR adds _get_reduction_args to remove duplicated code.
Please merge #2689 before this PR.

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Dec 2, 2019

Sorry for my late review. Could you resolve conflicts?

@asi1024 asi1024 added the cat:performance Performance in terms of speed or memory consumption label Dec 2, 2019
@okuta okuta force-pushed the improve-reduction-core branch from ed46fe3 to 86c0564 Compare December 2, 2019 07:42
@okuta
Copy link
Copy Markdown
Member Author

okuta commented Dec 2, 2019

I rebased.

@okuta
Copy link
Copy Markdown
Member Author

okuta commented Dec 2, 2019

jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Dec 2, 2019

Successfully created a job for commit 86c0564:

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 2, 2019

Jenkins CI test (for commit 86c0564, target branch master) succeeded!

@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Dec 2, 2019

This PR is just for code simplification? I compared the performance between this branch and by using cupy-perf, but I saw no performance improvement.

@asi1024 asi1024 mentioned this pull request Dec 2, 2019
Merged
@okuta
Copy link
Copy Markdown
Member Author

okuta commented Dec 2, 2019

This PR focuses simplify.
I want to send performance improvement PR after this PR.

@asi1024 asi1024 added cat:code-fix Code refactoring that do not change behavior and removed cat:performance Performance in terms of speed or memory consumption labels Dec 2, 2019
asi1024
asi1024 reviewed Dec 2, 2019
View reviewed changes
@okuta
Copy link
Copy Markdown
Member Author

okuta commented Dec 3, 2019

jenkins, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Dec 3, 2019

Successfully created a job for commit a339f3a:

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 3, 2019

Jenkins CI test (for commit a339f3a, target branch master) succeeded!

@asi1024 asi1024 added this to the v7.0.0 milestone Dec 3, 2019
@asi1024
Copy link
Copy Markdown
Member

asi1024 commented Dec 3, 2019

LGTM.

@asi1024 asi1024 merged commit 2410e6e into cupy:master Dec 3, 2019
@okuta okuta deleted the improve-reduction-core branch July 9, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asi1024 asi1024 asi1024 left review comments

Assignees

@asi1024 asi1024

Labels

cat:code-fix Code refactoring that do not change behavior

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@okuta @asi1024 @pfn-ci-bot @chainer-ci