Skip to content

Add prod_sequence to avoid creating vector#2689

Merged
niboshi merged 1 commit intocupy:masterfrom
okuta:add-prod_sequence
Nov 25, 2019
Merged

Add prod_sequence to avoid creating vector#2689
niboshi merged 1 commit intocupy:masterfrom
okuta:add-prod_sequence

Conversation

@okuta
Copy link
Copy Markdown
Member

@okuta okuta commented Nov 24, 2019

No description provided.

@okuta
Copy link
Copy Markdown
Member Author

okuta commented Nov 24, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit efd6c61:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit efd6c61, target branch master) failed with status FAILURE.

@okuta okuta force-pushed the add-prod_sequence branch from efd6c61 to a305601 Compare November 24, 2019 14:36
@okuta
Copy link
Copy Markdown
Member Author

okuta commented Nov 24, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit a305601:

@okuta okuta mentioned this pull request Nov 24, 2019
@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit a305601, target branch master) succeeded!

@niboshi
Copy link
Copy Markdown
Member

niboshi commented Nov 25, 2019

@okuta For performance improvements, it's better to indicate the actual measurement.

In my environment, with a tuple with 5 elements:
prod_sequence: 0.11 us
prod: 0.21 us

self.assertEqual(internal.prod([2, 3]), 6)


class TestProdSsizeT(unittest.TestCase):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep old tests.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This core is same as L9-18.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice... 🤔

@niboshi niboshi self-assigned this Nov 25, 2019
@niboshi
Copy link
Copy Markdown
Member

niboshi commented Nov 25, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit a305601:

@niboshi niboshi added cat:performance Performance in terms of speed or memory consumption st:test-and-merge (deprecated) Ready to merge after test pass. labels Nov 25, 2019
@niboshi niboshi added this to the v7.0.0 milestone Nov 25, 2019
@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit a305601, target branch master) failed with status FAILURE.

@niboshi
Copy link
Copy Markdown
Member

niboshi commented Nov 25, 2019

Jenkins, test this please

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

Successfully created a job for commit a305601:

@chainer-ci
Copy link
Copy Markdown
Member

Jenkins CI test (for commit a305601, target branch master) succeeded!

@niboshi
Copy link
Copy Markdown
Member

niboshi commented Nov 25, 2019

LGTM

@niboshi niboshi changed the title Add prod_sequence to avoid creating vector Add prod_sequence to avoid creating vector Nov 25, 2019
@niboshi niboshi merged commit 4586fed into cupy:master Nov 25, 2019
@okuta okuta deleted the add-prod_sequence branch December 2, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:performance Performance in terms of speed or memory consumption st:test-and-merge (deprecated) Ready to merge after test pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants