Skip to content

Fix ROCm build error#2632

Merged
Crissman merged 2 commits intocupy:masterfrom
kmaehashi:fix-cucomplex-rocm
Nov 13, 2019
Merged

Fix ROCm build error#2632
Crissman merged 2 commits intocupy:masterfrom
kmaehashi:fix-cucomplex-rocm

Conversation

@kmaehashi
Copy link
Copy Markdown
Member

@kmaehashi kmaehashi commented Nov 12, 2019 •
edited
Loading

@kmaehashi kmaehashi changed the title Fix ROCm build error [WIP] Fix ROCm build error Nov 12, 2019
@kmaehashi kmaehashi added the cat:bug Bugs label Nov 12, 2019
@leofang
Copy link
Copy Markdown
Member

leofang commented Nov 12, 2019

Oops, sorry I overlooked...

@Crissman Crissman self-assigned this Nov 13, 2019
@beam2d beam2d mentioned this pull request Nov 13, 2019
Closed
5 tasks
@kmaehashi kmaehashi changed the title [WIP] Fix ROCm build error Fix ROCm build error Nov 13, 2019
@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Nov 13, 2019

Can be merged after confirming this test succeeds: https://ci.preferred.jp/cupy.py3.amd/41936/

@leofang No worries, I should have added AMD tests to CIs. (ongoing: #2408)

@kmaehashi kmaehashi mentioned this pull request Nov 13, 2019
Merged
@Crissman
Copy link
Copy Markdown
Member

Crissman commented Nov 13, 2019

imosCI, test this please.

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Nov 13, 2019

Successfully created a job for commit 1d1cef5:

@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Nov 13, 2019

Can be merged after confirming this test succeeds: https://ci.preferred.jp/cupy.py3.amd/41936/

The test has passed. Now waiting for Jenkins...

@leofang
Copy link
Copy Markdown
Member

leofang commented Nov 13, 2019

Just curious, how many kinds of CIs do you have? I've seen Jenkins, pfnCI, and now imosCI 😲

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Nov 13, 2019

Jenkins CI test (for commit 1d1cef5, target branch master) succeeded!

@kmaehashi
Copy link
Copy Markdown
Member Author

kmaehashi commented Nov 13, 2019

Just curious, how many kinds of CIs do you have? I've seen Jenkins, pfnCI, and now imosCI 😲

Currently we are going to migrate from Jenkins to FlexCI. (For historical reasons... (1) FlexCI is also called pfnCI/imosCI but they are the same thing (2) pfnCI_test_this_please also triggers Jenkins 🤣)

@pfn-ci-bot
Copy link
Copy Markdown
Collaborator

pfn-ci-bot commented Nov 13, 2019

Successfully created a job for commit 1d1cef5:

@Crissman Crissman merged commit 0d97db9 into cupy:master Nov 13, 2019
@Crissman Crissman added this to the v7.0.0 milestone Nov 13, 2019
@kmaehashi kmaehashi deleted the fix-cucomplex-rocm branch November 13, 2019 09:06
@okuta okuta mentioned this pull request Nov 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Crissman Crissman

Labels

cat:bug Bugs

Projects

None yet

Milestone

v7.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kmaehashi @leofang @Crissman @pfn-ci-bot @chainer-ci