Remove redundant definitions in cupy_cufft.h#2560
Merged
asi1024 merged 1 commit intocupy:masterfrom Nov 1, 2019
Merged
Conversation
Member
|
LGTM. Jenkins, test this please. |
Collaborator
|
Successfully created a job for commit a0d5b5d: |
Member
|
Jenkins CI test (for commit a0d5b5d, target branch master) failed with status FAILURE. |
Member
Author
|
The only error is cryptic to me...@asi1024 are you able to decipher it for me? |
Member
|
Jenkins failure seems unrelated to this PR. |
Member
|
Jenkins, test this please. |
Collaborator
|
Successfully created a job for commit a0d5b5d: |
Member
|
Jenkins CI test (for commit a0d5b5d, target branch master) succeeded! |
Member
|
LGTM. Thank you for the PR! |
Member
Author
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex numbers are defined in
cupy_cuComplex.h, which gets included incupy_cuda.h. We should just take advantage of the existing ones.