Show better performance improvement in examples/stream/map_reduce.py#2588
Merged
emcastillo merged 1 commit intocupy:masterfrom Nov 5, 2019
Merged
Show better performance improvement in examples/stream/map_reduce.py#2588emcastillo merged 1 commit intocupy:masterfrom
examples/stream/map_reduce.py#2588emcastillo merged 1 commit intocupy:masterfrom
Conversation
Member
|
Jenkins, test this please |
Member
|
Jenkins CI test (for commit 4f861c2, target branch master) succeeded! |
emcastillo
pushed a commit
to emcastillo/cupy
that referenced
this pull request
Nov 5, 2019
Show better performance improvement in `examples/stream/map_reduce.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1695. Closes #2524.
In #1695 it was reported by @mrocklin that no concurrency was seen in the demo even with multiple streams. In #2524 it was found by @emcastillo that it was simply because the workload was too small. Increasing the workload helps observe stream overlap, see below.
Before this PR:
With this PR:
Tested on P100.