Skip to content

Add divmod function to cupy namespace#1286

Merged
beam2d merged 2 commits intocupy:masterfrom
okuta:fix-divmod-name
May 30, 2018
Merged

Add divmod function to cupy namespace#1286
beam2d merged 2 commits intocupy:masterfrom
okuta:fix-divmod-name

Conversation

@okuta
Copy link
Member

@okuta okuta commented May 28, 2018

This PR fix this error.

@okuta okuta added cat:enhancement Improvements to existing features to-be-backported Pull-requests to be backported to stable branch labels May 28, 2018
@okuta okuta added this to the v5.0.0b2 milestone May 28, 2018
@okuta okuta requested a review from beam2d May 28, 2018 06:56
@okuta okuta mentioned this pull request May 28, 2018
Merged
@beam2d
Copy link
Contributor

beam2d commented May 29, 2018

I tried this patch but the error still occurs. The error does not occur after writing cupy.divmod = cupy.core.divmod, so we have to put the symbol to cupy instead of fixing the argument of create_ufunc.

@okuta okuta force-pushed the fix-divmod-name branch from eb0ac0e to d5038b8 Compare May 29, 2018 12:04
@okuta okuta changed the title Fix divmod function name Add divmod function to cupy namespace May 29, 2018
@beam2d
Copy link
Contributor

beam2d commented May 30, 2018

Looks good.
Jenkins, test this please.

@beam2d
Copy link
Contributor

beam2d commented May 30, 2018

It looks NumPy <1.13 does not have divmod.

@okuta
Copy link
Member Author

okuta commented May 30, 2018

@beam2d I fixed test.

@beam2d
Copy link
Contributor

beam2d commented May 30, 2018

Thanks, LGTM

@beam2d beam2d merged commit f5f11af into cupy:master May 30, 2018
@beam2d beam2d changed the title Add divmod function to cupy namespace Add divmod function to cupy namespace May 30, 2018
@okuta okuta deleted the fix-divmod-name branch June 3, 2018 16:05
@chainer-ci
Copy link
Member

chainer-ci commented Jun 11, 2018

@beam2d This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

okuta pushed a commit to okuta/cupy that referenced this pull request Jun 11, 2018
@beam2d @okuta
Merge pull request cupy#1286 from okuta/fix-divmod-name
f1079d6 
Add divmod function to cupy namespace
@okuta okuta mentioned this pull request Jun 11, 2018
Closed
@toslunar
Copy link
Member

toslunar commented Jun 21, 2018

It seems the PR added cupy.divmod. Is this still an enhancement and OK to be backported?

@okuta okuta added cat:feature New features/APIs and removed cat:enhancement Improvements to existing features labels Jun 29, 2018
@okuta
Copy link
Member Author

okuta commented Jun 29, 2018

OK, I changed label.

@okuta okuta removed the to-be-backported Pull-requests to be backported to stable branch label Jun 29, 2018
@okuta
Copy link
Member Author

okuta commented Jul 23, 2018

I want backport this PR to support latest fusion function.

@okuta okuta added the to-be-backported Pull-requests to be backported to stable branch label Jul 23, 2018
okuta pushed a commit to okuta/cupy that referenced this pull request Jul 23, 2018
@beam2d @okuta
Merge pull request cupy#1286 from okuta/fix-divmod-name
5a0f53a 
Add divmod function to cupy namespace
@okuta okuta mentioned this pull request Jul 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beam2d beam2d Awaiting requested review from beam2d

Assignees

@beam2d beam2d

Labels

cat:feature New features/APIs to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v5.0.0b2

Development

Successfully merging this pull request may close these issues.

4 participants

@okuta @beam2d @chainer-ci @toslunar