Skip to content

Support rounding for complex types#1282

Merged
okuta merged 3 commits intocupy:masterfrom
unnonouno:complex-rounding
May 31, 2018
Merged

Support rounding for complex types#1282
okuta merged 3 commits intocupy:masterfrom
unnonouno:complex-rounding

Conversation

@unnonouno
Copy link
Copy Markdown
Contributor

@unnonouno unnonouno commented May 28, 2018

rint is applied to both real and imag.
related to #1281

@unnonouno unnonouno added cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch labels May 28, 2018
@unnonouno unnonouno mentioned this pull request May 28, 2018
Closed
5 tasks
@okuta okuta added this to the v5.0.0b2 milestone May 29, 2018
@okuta
Copy link
Copy Markdown
Member

okuta commented May 29, 2018

jenkins, test this please.

@okuta okuta self-assigned this May 29, 2018
@okuta
Copy link
Copy Markdown
Member

okuta commented May 29, 2018

Please fix following error.

cupy/core/elementwise.pxi:847: in cupy.core.core.create_ufunc
    cpdef create_ufunc(name, ops, routine=None, preamble='', doc='',
E   TypeError: create_ufunc() got an unexpected keyword argument 'support_complex'{

@okuta
Copy link
Copy Markdown
Member

okuta commented May 30, 2018

jenkins, test this please.

@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented May 30, 2018

Jenkins, test this please.

okuta
okuta requested changes May 30, 2018
View reviewed changes
cupy/math/rounding.py Outdated
.. seealso:: :func:`numpy.fix`

''')
''', support_complex=False)
Copy link
Copy Markdown
Member

@okuta okuta May 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this because this function is core.create_ufunc.

Copy link
Copy Markdown
Contributor Author

@unnonouno unnonouno May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

@okuta
Copy link
Copy Markdown
Member

okuta commented May 31, 2018

LGTM!

@okuta okuta merged commit 8992954 into cupy:master May 31, 2018
okuta added a commit to okuta/cupy that referenced this pull request May 31, 2018
@okuta
Merge pull request cupy#1282 from unnonouno/complex-rounding
9c25b9e 
Support rounding for complex types
@okuta okuta mentioned this pull request May 31, 2018
Merged
@unnonouno unnonouno deleted the complex-rounding branch May 31, 2018 05:01
@okuta okuta mentioned this pull request May 31, 2018
Closed
@kmaehashi kmaehashi mentioned this pull request May 31, 2018
Merged
okuta added a commit to okuta/cupy that referenced this pull request May 31, 2018
@okuta
Merge pull request cupy#1282 from unnonouno/complex-rounding
33e4a26 
Support rounding for complex types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@okuta okuta okuta approved these changes

Assignees

@okuta okuta

Labels

cat:bug Bugs to-be-backported Pull-requests to be backported to stable branch

Projects

None yet

Milestone

v5.0.0b2

Development

Successfully merging this pull request may close these issues.

3 participants

@unnonouno @okuta @kmaehashi