Remove deprecation from flags, update example to use CLI flags#498
Merged
Remove deprecation from flags, update example to use CLI flags#498
Conversation
Go API Changes# github.com/cucumber/godog ## compatible changes Feature: added # summary Inferred base version: v0.12.5 Suggested version: v0.13.0 |
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
==========================================
- Coverage 81.69% 81.50% -0.19%
==========================================
Files 27 27
Lines 2267 2282 +15
==========================================
+ Hits 1852 1860 +8
- Misses 316 321 +5
- Partials 99 101 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nhatthm
approved these changes
Aug 30, 2022
laurazard
pushed a commit
to laurazard/godog
that referenced
this pull request
Sep 11, 2022
…ber#498) * Remove deprecation from flags, update example to use CLI flags * Add comment to ShowHelp option * Fix test * Update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR
godog.BindFlags,godogsexample to use*testing.TandgodogCLI flags,godogsexample scenarios to showcase feature filtering with CLI flags,@TODO: sort by namefor list of available formatters,-helpand-pathsoptions togodog.BindFlagsfor better compatibility withgo test.⚡️ What's your motivation?
Recently there was a question about
godogflag usage when running withgo test.It turned out the most straightforward way to configure flags would be to use currently deprecated
godog.BindFlags.godogCLI now uses flag instrumentation based ongithub.com/spf13/pflag, however it is less suitable forgo testbecause it operates with stdlibflag.🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.