Adding version details to sidecar#385
Merged
Merged
Conversation
nixpanic
reviewed
Jun 26, 2023
Member
|
Many thanks for you contribution! I think it will be very helpful 👍 |
523319c to
957a79d
Compare
57407fe to
c0c88b4
Compare
nixpanic
reviewed
Jun 26, 2023
nixpanic
previously approved these changes
Jun 26, 2023
Contributor
Author
|
@Rakshith-R & @yati1998 can you please check and approve |
Rakshith-R
requested changes
Jun 26, 2023
85c93a7 to
adda110
Compare
Rakshith-R
previously approved these changes
Jun 27, 2023
Contributor
Author
|
can someone help me understand why build is failing. |
Member
I think there is spacing issue in the import "time" pkg line. https://github.com/csi-addons/kubernetes-csi-addons/actions/runs/5385350011/jobs/9774541855?pr=385 and after amending your commit, check if that change still exists with |
Madhu-1
reviewed
Jun 27, 2023
Madhu-1
approved these changes
Jun 27, 2023
Rakshith-R
approved these changes
Jun 27, 2023
Member
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Member
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Member
|
@saranyareddy24 Can you please try logging into mergifyio |
Member
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Member
|
@Mergifyio rebase |
Signed-off-by: saranyareddy24 <saranyareddipalle@yahoo.in>
✅ Branch has been successfully rebased |
nixpanic
added a commit
to nixpanic/kubernetes-csi-addons
that referenced
this pull request
Jun 27, 2023
The `Makefile` now contains logic to provide a version (git tag) and the current git commit hash in a `-version` argument to executables. However the container-images did not use `make`, and therefor the executables would not have the version information set. While updating the building of the executables in the container, the names of the executables has been prefixed with `csi-addons-`, so that a listing of running processes on a Kubernetes node does not show `manager` for the CSI-Addons Operator, but `csi-addons-manager`. Updates: csi-addons#385 Signed-off-by: Niels de Vos <ndevos@ibm.com>
mergify Bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
The `Makefile` now contains logic to provide a version (git tag) and the current git commit hash in a `-version` argument to executables. However the container-images did not use `make`, and therefor the executables would not have the version information set. While updating the building of the executables in the container, the names of the executables has been prefixed with `csi-addons-`, so that a listing of running processes on a Kubernetes node does not show `manager` for the CSI-Addons Operator, but `csi-addons-manager`. Updates: #385 Signed-off-by: Niels de Vos <ndevos@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377
Fixes #378
The output will be printed as:
Version: v0.6.0
Git Commit: 43ebc4b
Go Version: go1.19.9
Compiler: gc
Platform: linux/amd64