add default value to autoResync#304
Merged
mergify[bot] merged 1 commit intoFeb 15, 2023
Merged
Conversation
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
Madhu-1
approved these changes
Feb 15, 2023
|
LGTM, from a ramen usage perspective, we always set the value, hence the default will not be picked up (and also the default as false is correct even in case it is not specified) |
yati1998
approved these changes
Feb 15, 2023
|
Shyam, |
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
Jun 24, 2025
Syncing latest changes from upstream main for kubernetes-csi-addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a user will want to create
VolumeReplicationwithout theautoResyncfield it will fail because it’s a required field. After this PR it will have a default in the CRD and it won’t fail and will create the object with the default value