replication: update LastSyncTime if its not nill#260
Merged
Conversation
ShyamsundarR
left a comment
There was a problem hiding this comment.
This works to not update last known lastSyncTime in cases where the call does not return a value, or hold it at epoch till it does.
NOTE: As I have not cross-checked other areas of code not approving as such.
yati1998
previously approved these changes
Oct 31, 2022
Member
Author
|
@nixpanic PTAL |
nixpanic
requested changes
Oct 31, 2022
nixpanic
left a comment
Member
There was a problem hiding this comment.
Marking this -1 until the discussion in csi-addons/spec#47 is resolved.
Pull request has been modified.
nixpanic
approved these changes
Nov 1, 2022
Member
Author
|
@Mergifyio rebase |
LastSyncTime can be optional and nil also, there is no strict check for it and if we dont have this check the default UNIX time will get added to the CR which doesnt make sense. If the time is not present keeping the last known LastSyncTime itself. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
csi-addons/spec#47 has the defined errors for the GetVolumeReplicationInfo RPC call. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Added known error for GetVolumeReplicationInfo RPC call as per the predefined error messages in the csiaddons spec. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
✅ Branch has been successfully rebased |
c31bad2 to
8df5465
Compare
yati1998
approved these changes
Nov 2, 2022
iPraveenParihar
pushed a commit
to iPraveenParihar/kubernetes-csi-addons
that referenced
this pull request
Apr 15, 2025
Syncing latest changes from main for kubernetes-csi-addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastSyncTime can be optional and nil also, there is no strict check for it, and if we dont have this check the default UNIX time will get added to the CR, which doesn't make sense. If the time is not present keep the last known LastSyncTime itself.
Depends-On: csi-addons/spec#47