build: add tools to (re)generate protobuf files after modification#233
Merged
Conversation
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
860c9e9 to
1450879
Compare
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
1450879 to
cddf218
Compare
yati1998
approved these changes
Sep 9, 2022
Rakshith-R
approved these changes
Sep 12, 2022
Madhu-1
pushed a commit
to Madhu-1/kubernetes-csi-addons
that referenced
this pull request
Nov 27, 2024
Syncing latest changes from main for kubernetes-csi-addons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
internal/protopackage contains raw.protofiles that are the input for the related*.pb.gofiles. It seems the.gofiles were generated manually, and checked into the repository. This is not ideal, as manual changes to those files will likely go unnoticed.By adding a
internal/proto/generate.gofile that only containsgo:generatebuild-tags, the.protofiles can be regenerated on-demand. A newmake generate-protobuftarget has been added that builds the required protoc-plugins before generating the*.pb.gofiles.