Move prediatation inside block/gridReduciton functions#376
Merged
naoyam merged 1 commit into20_8_18_develfrom Sep 14, 2020
Merged
Move prediatation inside block/gridReduciton functions#376naoyam merged 1 commit into20_8_18_develfrom
naoyam merged 1 commit into20_8_18_develfrom
Conversation
952556e to
3eb8a1c
Compare
tlemo
approved these changes
Sep 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the GEMM PR (#368). Since that PR has several independent changes, I just extracted the specific changes that are related to
blockReduceandgridReducedevice functions. These functions now accept predicate flags that indicate whether a thread should join the reduction. The change is meant to fix the deadlock issue (#365).