Move sharedfolder upload notifications to publicshare provider #5427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
c84d2c9 to
ae807b2
Compare
83dce80 to
2cb31db
Compare
2cb31db to
e6d7556
Compare
glpatcern
approved these changes
Dec 10, 2025
Member
glpatcern
left a comment
There was a problem hiding this comment.
Looks good, especially with the logic to RegisterNotification and UnregisterNotification now in the publicshareprovider
jessegeens
added a commit
that referenced
this pull request
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The registration of notifications for uploads in a public link folder was until now only handled in the OCS HTTP layer; this is the responsibility of the public share provider. Since it was also missing from the OCGraph layer, this has been moved to the "gRPC" part of reva